Add error pages for one login journey#2071
Merged
stephencdaly merged 3 commits intomainfrom Apr 30, 2026
Merged
Conversation
stephencdaly
force-pushed
the
add-error-pages-for-one-login-journey
branch
from
511cf42 to
3ded715
Compare
Contributor
Author
|
@StephenGill could you double-check the content is correct in this one please? |
|
Copy looks good to me |
DavidBiddle
reviewed
Apr 30, 2026
DavidBiddle
reviewed
Apr 30, 2026
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
All looks good aside from those HTML issues raised above - I've tested locally and everything else works as expected
This page has a link to go back to the copy of your answers page so the user can try again if they wish.
Render a dedicated error page when we are returned from One Login and we don't know which form to return the user to because their session is missing.
We log the user out from One Login if they've opted to receive a copy of their answers when they submit the form. This involves redirecting them to One Login, and then they are returned to a URL on our service which is not form specific. We store details of the form they submitted in the session so we know where to return them to. If somehow the user's session is lost when they're returned to us from One Login, we still want to tell the user that their form has been submitted, even if we don't know which form. Render a generic page and log an error in this case.
stephencdaly
force-pushed
the
add-error-pages-for-one-login-journey
branch
from
3ded715 to
602e2f7
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2071.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/tKtA1VPQ/2858-create-integration-with-one-login
Add error pages for the following scenarios:
The auth details are missing or there is an unexpected error authorising with One Login
The user's session has been lost when they're returned to us from One Login
The user's session has been lost after they've been logged out when they submit their form
In this case, rather than showing an error, show a generic success page without the form details as the user's form will still have been submitted and we should have sent them an email with their answers.
Things to consider when reviewing